fix: align frontend zod schemas with backend validation rules
Tightened frontend zod schemas where backend required fields the frontend marked optional, and matched enum/format constraints. Schemas: - vehicle-document: document_type required - parts: shop_type, category, unit_type, department, sku required - inspections: customer, vehicle, department, inspection_category, employee, order_number, date, time required - appointments: service_writer required, cross-field to_time > from_time - vendor-credits: vendor + vendor_credit_date required - job-cards: documents[].document_type_id required - expense-items: category, unit_type, department, sku required - inventory-adjustments: reference_number, date required - tasks: task_type, task_section required - shop-timings: in_time, out_time enforce HH:MM:SS regex - vendor-credit: subject + vendor + vendor_credit_date required Settings: - shop-type: shop_type + note required - insurance-types: description field added, required - make-and-models: shop_type required, year 1900..2100 - departments: assignment_type required enum (AssignmentType) - company: website URL validation, latitude/longitude range, first_day_of_work enum, string max lengths - configurations: 4 fields enum-typed (was raw strings) Inline forms: - job-card service/part/expense-item: relations required (part/service/expense_item/department) - job-card recommendation: max 255 - vehicles/inline-forms/shop-type: shop_type + note required - vehicles/inline-forms/body-type: shop_type_id pulled from parent form context, guard on submit - vehicles/inline-forms/color: code field added, required - services/inline-forms/department: assignment_type required enum - tasks/task-section: arrangement required integer - invoices/invoice-edit: status + discount enum-typed Auth: - login: password min 6 (was 8; backend allows 6) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
349a458c3c
commit
cc7dc1bd17
@@ -1,24 +1,30 @@
|
||||
import { z } from "zod"
|
||||
import {
|
||||
SellRatesTaxInclusive,
|
||||
GiveDiscounts,
|
||||
PurchaseRatesTaxInclusive,
|
||||
ReceiveDiscounts,
|
||||
} from "@garage/api"
|
||||
|
||||
export const salesConfigFormSchema = z.object({
|
||||
sell_rates_tax_inclusive: z.string().optional(),
|
||||
give_discounts: z.string().optional(),
|
||||
sell_rates_tax_inclusive: z.enum(SellRatesTaxInclusive).optional(),
|
||||
give_discounts: z.enum(GiveDiscounts).optional(),
|
||||
})
|
||||
|
||||
export type SalesConfigFormValues = z.infer<typeof salesConfigFormSchema>
|
||||
|
||||
export const purchaseConfigFormSchema = z.object({
|
||||
purchase_rates_tax_inclusive: z.string().optional(),
|
||||
receive_discounts: z.string().optional(),
|
||||
purchase_rates_tax_inclusive: z.enum(PurchaseRatesTaxInclusive).optional(),
|
||||
receive_discounts: z.enum(ReceiveDiscounts).optional(),
|
||||
})
|
||||
|
||||
export type PurchaseConfigFormValues = z.infer<typeof purchaseConfigFormSchema>
|
||||
|
||||
export const generalPreferencesFormSchema = z.object({
|
||||
sell_rates_tax_inclusive: z.string().optional(),
|
||||
give_discounts: z.string().optional(),
|
||||
purchase_rates_tax_inclusive: z.string().optional(),
|
||||
receive_discounts: z.string().optional(),
|
||||
sell_rates_tax_inclusive: z.enum(SellRatesTaxInclusive).optional(),
|
||||
give_discounts: z.enum(GiveDiscounts).optional(),
|
||||
purchase_rates_tax_inclusive: z.enum(PurchaseRatesTaxInclusive).optional(),
|
||||
receive_discounts: z.enum(ReceiveDiscounts).optional(),
|
||||
})
|
||||
|
||||
export type GeneralPreferencesFormValues = z.infer<typeof generalPreferencesFormSchema>
|
||||
|
||||
@@ -23,10 +23,10 @@ const DISCOUNT_OPTIONS = DiscountType.map((v) => ({
|
||||
}))
|
||||
|
||||
const DEFAULT_VALUES: GeneralPreferencesFormValues = {
|
||||
sell_rates_tax_inclusive: "",
|
||||
give_discounts: "",
|
||||
purchase_rates_tax_inclusive: "",
|
||||
receive_discounts: "",
|
||||
sell_rates_tax_inclusive: undefined,
|
||||
give_discounts: undefined,
|
||||
purchase_rates_tax_inclusive: undefined,
|
||||
receive_discounts: undefined,
|
||||
}
|
||||
|
||||
export function GeneralPreferencesForm() {
|
||||
|
||||
@@ -23,8 +23,8 @@ const DISCOUNT_OPTIONS = DiscountType.map((v) => ({
|
||||
}))
|
||||
|
||||
const DEFAULT_VALUES: PurchaseConfigFormValues = {
|
||||
purchase_rates_tax_inclusive: "",
|
||||
receive_discounts: "",
|
||||
purchase_rates_tax_inclusive: undefined,
|
||||
receive_discounts: undefined,
|
||||
}
|
||||
|
||||
export function PurchaseConfigForm() {
|
||||
|
||||
@@ -23,8 +23,8 @@ const DISCOUNT_OPTIONS = DiscountType.map((v) => ({
|
||||
}))
|
||||
|
||||
const DEFAULT_VALUES: SalesConfigFormValues = {
|
||||
sell_rates_tax_inclusive: "",
|
||||
give_discounts: "",
|
||||
sell_rates_tax_inclusive: undefined,
|
||||
give_discounts: undefined,
|
||||
}
|
||||
|
||||
export function SalesConfigForm() {
|
||||
|
||||
Reference in New Issue
Block a user