fix: align frontend zod schemas with backend validation rules
Tightened frontend zod schemas where backend required fields the frontend marked optional, and matched enum/format constraints. Schemas: - vehicle-document: document_type required - parts: shop_type, category, unit_type, department, sku required - inspections: customer, vehicle, department, inspection_category, employee, order_number, date, time required - appointments: service_writer required, cross-field to_time > from_time - vendor-credits: vendor + vendor_credit_date required - job-cards: documents[].document_type_id required - expense-items: category, unit_type, department, sku required - inventory-adjustments: reference_number, date required - tasks: task_type, task_section required - shop-timings: in_time, out_time enforce HH:MM:SS regex - vendor-credit: subject + vendor + vendor_credit_date required Settings: - shop-type: shop_type + note required - insurance-types: description field added, required - make-and-models: shop_type required, year 1900..2100 - departments: assignment_type required enum (AssignmentType) - company: website URL validation, latitude/longitude range, first_day_of_work enum, string max lengths - configurations: 4 fields enum-typed (was raw strings) Inline forms: - job-card service/part/expense-item: relations required (part/service/expense_item/department) - job-card recommendation: max 255 - vehicles/inline-forms/shop-type: shop_type + note required - vehicles/inline-forms/body-type: shop_type_id pulled from parent form context, guard on submit - vehicles/inline-forms/color: code field added, required - services/inline-forms/department: assignment_type required enum - tasks/task-section: arrangement required integer - invoices/invoice-edit: status + discount enum-typed Auth: - login: password min 6 (was 8; backend allows 6) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.7
parent
349a458c3c
commit
cc7dc1bd17
@@ -36,7 +36,7 @@ const requiredRelationFieldSchema = relationFieldSchema.superRefine((value, ctx)
|
||||
})
|
||||
|
||||
const jobCardExpenseItemFormSchema = z.object({
|
||||
expense_item: relationFieldSchema,
|
||||
expense_item: requiredRelationFieldSchema,
|
||||
department: requiredRelationFieldSchema,
|
||||
tax: relationFieldSchema.optional(),
|
||||
quantity: z.coerce.number().min(1, "Quantity is required"),
|
||||
|
||||
@@ -27,8 +27,8 @@ import { useJobCard } from "./job-card-context"
|
||||
const relationFieldSchema = z.object({ value: z.string(), label: z.string() }).nullable()
|
||||
|
||||
const jobCardPartFormSchema = z.object({
|
||||
part: relationFieldSchema,
|
||||
department: relationFieldSchema.optional(),
|
||||
part: relationFieldSchema.refine((val) => !!val?.value, "Part is required"),
|
||||
department: relationFieldSchema.refine((val) => !!val?.value, "Department is required"),
|
||||
tax: relationFieldSchema.optional(),
|
||||
quantity: z.coerce.number().min(1, "Quantity is required"),
|
||||
rate: z.coerce.number().min(0, "Rate is required"),
|
||||
|
||||
@@ -11,7 +11,7 @@ import { toast } from "sonner"
|
||||
import { useAuthApi } from "@/shared/useApi"
|
||||
|
||||
const schema = z.object({
|
||||
recommendation: z.string().min(1, "Recommendation is required"),
|
||||
recommendation: z.string().min(1, "Recommendation is required").max(255, "Recommendation cannot exceed 255 characters"),
|
||||
})
|
||||
|
||||
type FormValues = z.infer<typeof schema>
|
||||
|
||||
@@ -28,8 +28,8 @@ import { useJobCard } from "./job-card-context"
|
||||
const relationFieldSchema = z.object({ value: z.string(), label: z.string() }).nullable()
|
||||
|
||||
const jobCardServiceFormSchema = z.object({
|
||||
service: relationFieldSchema,
|
||||
department: z.object({ value: z.string(), label: z.string() }),
|
||||
service: relationFieldSchema.refine((val) => !!val?.value, "Service is required"),
|
||||
department: z.object({ value: z.string(), label: z.string() }, { error: "Department is required" }),
|
||||
tax: relationFieldSchema.optional(),
|
||||
rate_type: z.string().optional(),
|
||||
labor_rate: relationFieldSchema.optional(),
|
||||
|
||||
@@ -16,7 +16,7 @@ const optionalStringMax255 = z.string().max(255).optional()
|
||||
const optionalTimeString = z.string().max(50).optional()
|
||||
|
||||
const documentSchema = z.object({
|
||||
document_type_id: z.coerce.number().int().optional(),
|
||||
document_type_id: z.coerce.number({ error: "Document type is required" }).int(),
|
||||
customer_id: z.coerce.number().int().optional(),
|
||||
vehicle_id: z.coerce.number().int().optional(),
|
||||
document_number: z.string().optional(),
|
||||
|
||||
Reference in New Issue
Block a user