fix(dashboard): resolve Asma tester-reported UI issues
- 3.1 currency: replace hardcoded $ with AED <Money/> in item & job-card price cells - 5.1 calendar: /calendars now renders the month calendar (was redirect to list) - 7.2 nav: remove dead Time Clocks / Time Sheets links (no routes, 404) - 5.4 check-in: enforce required department at schema level - 5.6 payments received: add invoice picker so the invoice is marked Paid - 5.2 share link: forward ws workspace param from the public inspection page Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
0171daea38
commit
11d920ba6a
@@ -24,6 +24,7 @@ import { toast } from "sonner"
|
||||
import { Ellipsis, Plus } from "lucide-react"
|
||||
import type { ColumnDef } from "@tanstack/react-table"
|
||||
import { JobCardExpenseItemForm } from "@/modules/job-cards/job-card-expense-item-form"
|
||||
import { Money } from "@/shared/components/money"
|
||||
import { formatDate } from "@/shared/utils/formatters"
|
||||
// TODO: expense items invalidation is not working properly when create new expense item line. Need to investigate why and fix it.
|
||||
|
||||
@@ -93,7 +94,7 @@ export default function JobCardExpenseItemsPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Rate" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.rate
|
||||
return val != null ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
@@ -101,7 +102,7 @@ export default function JobCardExpenseItemsPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Discount" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.discount_amount
|
||||
return val != null && val > 0 ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null && val > 0 ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
|
||||
@@ -24,6 +24,7 @@ import { toast } from "sonner"
|
||||
import { Ellipsis, Plus } from "lucide-react"
|
||||
import type { ColumnDef } from "@tanstack/react-table"
|
||||
import { JobCardPartForm } from "@/modules/job-cards/job-card-part-form"
|
||||
import { Money } from "@/shared/components/money"
|
||||
import { formatDate } from "@/shared/utils/formatters"
|
||||
import { JOB_CARD_ROUTES } from "@garage/api"
|
||||
|
||||
@@ -93,7 +94,7 @@ export default function JobCardPartsPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Rate" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.rate
|
||||
return val != null ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
@@ -101,7 +102,7 @@ export default function JobCardPartsPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Discount" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.discount_amount
|
||||
return val != null && val > 0 ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null && val > 0 ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
|
||||
@@ -24,6 +24,7 @@ import { toast } from "sonner"
|
||||
import { Ellipsis, Plus } from "lucide-react"
|
||||
import type { ColumnDef } from "@tanstack/react-table"
|
||||
import { JobCardServiceForm } from "@/modules/job-cards/job-card-service-form"
|
||||
import { Money } from "@/shared/components/money"
|
||||
import { formatDate } from "@/shared/utils/formatters"
|
||||
import { Badge } from "@/shared/components/ui/badge"
|
||||
|
||||
@@ -108,7 +109,7 @@ export default function JobCardServicesPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Rate" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.rate
|
||||
return val != null ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
@@ -116,7 +117,7 @@ export default function JobCardServicesPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Labor Rate" />,
|
||||
cell: ({ row }) => {
|
||||
const lr = row.original.labor_rate
|
||||
return lr ? `${lr.title} ($${Number(lr.rate).toFixed(2)})` : "—"
|
||||
return lr ? <span>{lr.title} (<Money value={lr.rate} />)</span> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
@@ -134,7 +135,7 @@ export default function JobCardServicesPage({
|
||||
header: ({ column }) => <ColumnHeader column={column} title="Discount" />,
|
||||
cell: ({ row }) => {
|
||||
const val = row.original.discount_amount
|
||||
return val != null && val > 0 ? `$${Number(val).toFixed(2)}` : "—"
|
||||
return val != null && val > 0 ? <Money value={val} /> : "—"
|
||||
},
|
||||
},
|
||||
{
|
||||
|
||||
Reference in New Issue
Block a user